The Rover-Landers of BC

My battery dies overnight, am I looking at a faulty ignition switch. I thought if it was a dead short there would be a smoking wire or something, thoughts or ideas.

You pretty much need to take an ammeter between the battery and the main lead and just start disconnecting each circuit until you find what is drawing power.

You can quickly run through all of the fused items and if that is not it work to infused items like the alternator, starter and ignition switch. Helps to start with a wiring schematic and check off each item as you go through them.

Thanks. I'll try that.

Also get your battery checked or tested, maybe you have a dry or dead cell?

Is the battery secured down well? Often a loose battery will bounce around and be shorting out on the metal cover under the seat.
Always a good idea to have a flat piece of rubber between the top of the battery and the metal seat box cover.

Thanks, I'll do that.